Chore: internal refactor replication::Data #944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make `replication::Data` a enum, and enable using its variants `Logs(l)` and `Snapshot(s)` directly.
drmingdrmer
force-pushed
the
27-replication-data
branch
from
838e01b to
90e47d5
Compare
lichuang
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Chore: internal refactor replication::Data
Make
replication::Dataa enum, and enable using its variantsLogs(l)and
Snapshot(s)directly.Chore: simplify usage of C::AsyncRuntime in replication/mod.rs
Chore: move partial success checking to separate function
This change is